From d4d0a488eb6f9456df2fa7fc9348c5076ee7dfab Mon Sep 17 00:00:00 2001 From: John Keeping Date: Sun, 13 Feb 2022 15:34:50 +0000 Subject: global: use release_commit_memory() Instead of calling two separate Git functions to free memory associated with a commit object, use Git's wrapper which does this. This also counts as a potential future bug fix since release_commit_memory() also resets the parsed state of the commit, meaning any attempt to use it in the future will correctly fill out the fields again. release_commit_memory() does not set parents to zero, so keep that for additional safety in case CGit checks this without calling parse_commit() again. Signed-off-by: John Keeping Signed-off-by: Jason A. Donenfeld --- ui-stats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'ui-stats.c') diff --git a/ui-stats.c b/ui-stats.c index 8b7e70c..6d0296d 100644 --- a/ui-stats.c +++ b/ui-stats.c @@ -241,8 +241,7 @@ static struct string_list collect_stats(const struct cgit_period *period) memset(&authors, 0, sizeof(authors)); while ((commit = get_revision(&rev)) != NULL) { add_commit(&authors, commit, period); - free_commit_buffer(the_repository->parsed_objects, commit); - free_commit_list(commit->parents); + release_commit_memory(the_repository->parsed_objects, commit); commit->parents = NULL; } return authors; -- cgit v1.2.3-70-g09d2