From 4468ec1b15becf3838d8cf38440c527c487565a4 Mon Sep 17 00:00:00 2001 From: Peter Wu Date: Thu, 3 Oct 2013 12:17:23 +0200 Subject: Reduce line number bloat, fix hover effect Currently line numbers look like (for blob view and sdiff respectively): 68 1 name=".." is unnecessary if the id attribute is set (this even applies to IE6), so drop it. (aside, in HTML5, the name attribute is gone.) The line number links can be selected through their parent classes, no need for another class "no", so drop it too. For a file with 2000 lines, this yields a saving of 40% (29% gzipped). While at it, fix the hover effect of line numbers: now the line number get a black background as was intended. Signed-off-by: Peter Wu Signed-off-by: Lukas Fleischer --- ui-ssdiff.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'ui-ssdiff.c') diff --git a/ui-ssdiff.c b/ui-ssdiff.c index cbe60bd..08cf513 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -230,9 +230,9 @@ static void print_ssdiff_line(char *class, struct diff_filespec *old_file = cgit_get_current_old_file(); char *lineno_str = fmt("n%d", old_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(old_file->sha1)?"HEAD":sha1_to_hex(old_rev_sha1), lineno_str); - html("%s", lineno_str, lineno_str, lineno_str + 1); + htmlf("' id='%s'>%s", lineno_str, lineno_str + 1); html(""); htmlf("", class); } else if (old_line) @@ -251,9 +251,9 @@ static void print_ssdiff_line(char *class, struct diff_filespec *new_file = cgit_get_current_new_file(); char *lineno_str = fmt("n%d", new_line_no); char *id_str = fmt("id=%s#%s", is_null_sha1(new_file->sha1)?"HEAD":sha1_to_hex(new_rev_sha1), lineno_str); - html("%s", lineno_str, lineno_str, lineno_str + 1); + htmlf("' id='%s'>%s", lineno_str, lineno_str + 1); html(""); htmlf("", class); } else if (new_line) -- cgit v1.2.3-70-g09d2