From 9927e63f387e6c9328eb3c347ecb0e339f8ac023 Mon Sep 17 00:00:00 2001 From: Lars Hjemli Date: Mon, 14 May 2007 23:58:29 +0200 Subject: Specify static storage class for file-local declarations Also fix some whitespace issues while at it. Noticed by Kristian Høgsberg Signed-off-by: Lars Hjemli --- ui-commit.c | 8 ++++---- ui-summary.c | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/ui-commit.c b/ui-commit.c index 20a7cb2..b6a106f 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -8,11 +8,11 @@ #include "cgit.h" -int files = 0, slots = 0; -int total_adds = 0, total_rems = 0, max_changes = 0; -int lines_added, lines_removed; +static int files, slots; +static int total_adds, total_rems, max_changes; +static int lines_added, lines_removed; -struct fileinfo { +static struct fileinfo { char status; unsigned char old_sha1[20]; unsigned char new_sha1[20]; diff --git a/ui-summary.c b/ui-summary.c index 9388f5f..f6120f9 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -8,7 +8,7 @@ #include "cgit.h" -int items = 0; +static int items; static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, int flags, void *cb_data) @@ -22,7 +22,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, if (commit && !parse_commit(commit)){ info = cgit_parse_commit(commit); html(""); - url = cgit_pageurl(cgit_query_repo, "log", + url = cgit_pageurl(cgit_query_repo, "log", fmt("h=%s", refname)); html_link_open(url, NULL, NULL); html_txt(buf); @@ -32,7 +32,7 @@ static int cgit_print_branch_cb(const char *refname, const unsigned char *sha1, html(""); html_txt(info->author); html(""); - url = cgit_pageurl(cgit_query_repo, "commit", + url = cgit_pageurl(cgit_query_repo, "commit", fmt("id=%s", sha1_to_hex(sha1))); html_link_open(url, NULL, NULL); html_ntxt(cgit_max_msg_len, info->subject); @@ -61,10 +61,10 @@ static void cgit_print_object_ref(struct object *obj) else page = "view"; - url = cgit_pageurl(cgit_query_repo, page, + url = cgit_pageurl(cgit_query_repo, page, fmt("id=%s", sha1_to_hex(obj->sha1))); html_link_open(url, NULL, NULL); - htmlf("%s %s", typename(obj->type), + htmlf("%s %s", typename(obj->type), sha1_to_hex(obj->sha1)); html_link_close(); } @@ -76,7 +76,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1, struct taginfo *info; struct object *obj; char buf[256], *url; - + strncpy(buf, refname, sizeof(buf)); obj = parse_object(sha1); if (!obj) @@ -93,7 +93,7 @@ static int cgit_print_tag_cb(const char *refname, const unsigned char *sha1, } items++; html(""); - url = cgit_pageurl(cgit_query_repo, "view", + url = cgit_pageurl(cgit_query_repo, "view", fmt("id=%s", sha1_to_hex(sha1))); html_link_open(url, NULL, NULL); html_txt(buf); -- cgit v1.2.3-70-g09d2