diff options
Diffstat (limited to 'shared.c')
-rw-r--r-- | shared.c | 7 |
1 files changed, 4 insertions, 3 deletions
@@ -459,7 +459,6 @@ void cgit_prepare_repo_env(struct cgit_repo * repo) | |||
459 | 459 | ||
460 | int cgit_open_filter(struct cgit_filter *filter) | 460 | int cgit_open_filter(struct cgit_filter *filter) |
461 | { | 461 | { |
462 | |||
463 | filter->old_stdout = chk_positive(dup(STDOUT_FILENO), | 462 | filter->old_stdout = chk_positive(dup(STDOUT_FILENO), |
464 | "Unable to duplicate STDOUT"); | 463 | "Unable to duplicate STDOUT"); |
465 | chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess"); | 464 | chk_zero(pipe(filter->pipe_fh), "Unable to create pipe to subprocess"); |
@@ -480,13 +479,15 @@ int cgit_open_filter(struct cgit_filter *filter) | |||
480 | 479 | ||
481 | int cgit_close_filter(struct cgit_filter *filter) | 480 | int cgit_close_filter(struct cgit_filter *filter) |
482 | { | 481 | { |
482 | int exit_status; | ||
483 | |||
483 | chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO), | 484 | chk_non_negative(dup2(filter->old_stdout, STDOUT_FILENO), |
484 | "Unable to restore STDOUT"); | 485 | "Unable to restore STDOUT"); |
485 | close(filter->old_stdout); | 486 | close(filter->old_stdout); |
486 | if (filter->pid < 0) | 487 | if (filter->pid < 0) |
487 | return 0; | 488 | return 0; |
488 | waitpid(filter->pid, &filter->exitstatus, 0); | 489 | waitpid(filter->pid, &exit_status, 0); |
489 | if (WIFEXITED(filter->exitstatus) && !WEXITSTATUS(filter->exitstatus)) | 490 | if (WIFEXITED(exit_status) && !WEXITSTATUS(exit_status)) |
490 | return 0; | 491 | return 0; |
491 | die("Subprocess %s exited abnormally", filter->cmd); | 492 | die("Subprocess %s exited abnormally", filter->cmd); |
492 | } | 493 | } |