aboutsummaryrefslogtreecommitdiffstats
path: root/ui-atom.c
diff options
context:
space:
mode:
authorJohn Keeping2022-02-13 15:34:50 +0000
committerYigit Sever2023-07-21 03:03:51 +0300
commitd4d0a488eb6f9456df2fa7fc9348c5076ee7dfab (patch)
tree96f7f7aa09047ea99e12d35bf5bd76555b7583d0 /ui-atom.c
parent443ec893ab98238a6327a40e61633a53ab95b86c (diff)
downloadcgit-d4d0a488eb6f9456df2fa7fc9348c5076ee7dfab.tar.gz
cgit-d4d0a488eb6f9456df2fa7fc9348c5076ee7dfab.tar.bz2
cgit-d4d0a488eb6f9456df2fa7fc9348c5076ee7dfab.zip
global: use release_commit_memory()
Instead of calling two separate Git functions to free memory associated with a commit object, use Git's wrapper which does this. This also counts as a potential future bug fix since release_commit_memory() also resets the parsed state of the commit, meaning any attempt to use it in the future will correctly fill out the fields again. release_commit_memory() does not set parents to zero, so keep that for additional safety in case CGit checks this without calling parse_commit() again. Signed-off-by: John Keeping <john@keeping.me.uk> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to 'ui-atom.c')
-rw-r--r--ui-atom.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/ui-atom.c b/ui-atom.c
index 541660d..5f4ad7d 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -149,8 +149,7 @@ void cgit_print_atom(char *tip, const char *path, int max_count)
149 first = false; 149 first = false;
150 } 150 }
151 add_entry(commit, host); 151 add_entry(commit, host);
152 free_commit_buffer(the_repository->parsed_objects, commit); 152 release_commit_memory(the_repository->parsed_objects, commit);
153 free_commit_list(commit->parents);
154 commit->parents = NULL; 153 commit->parents = NULL;
155 } 154 }
156 html("</feed>\n"); 155 html("</feed>\n");