diff options
author | Lars Hjemli | 2007-11-06 00:35:12 +0100 |
---|---|---|
committer | Lars Hjemli | 2007-11-06 00:35:12 +0100 |
commit | d04c4734bcf40b1d17c55b18fba2aa8344678e8f (patch) | |
tree | e08d0141da1b0b9ab2f921f1a7efd141b32dfe49 | |
parent | 72ede12551af320b6d8eade853dbd2cd6f2222cc (diff) | |
download | cgit-d04c4734bcf40b1d17c55b18fba2aa8344678e8f.tar.gz cgit-d04c4734bcf40b1d17c55b18fba2aa8344678e8f.tar.bz2 cgit-d04c4734bcf40b1d17c55b18fba2aa8344678e8f.zip |
Show lines changed as -n/+m in shortlogs
This is way more informative than the total number of changed lines.
Suggested-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
-rw-r--r-- | ui-log.c | 21 |
1 files changed, 14 insertions, 7 deletions
@@ -8,12 +8,18 @@ | |||
8 | 8 | ||
9 | #include "cgit.h" | 9 | #include "cgit.h" |
10 | 10 | ||
11 | int files, lines; | 11 | int files, add_lines, rem_lines; |
12 | 12 | ||
13 | void count_lines(char *line, int size) | 13 | void count_lines(char *line, int size) |
14 | { | 14 | { |
15 | if (size>0 && (line[0] == '+' || line[0] == '-')) | 15 | if (size <= 0) |
16 | lines++; | 16 | return; |
17 | |||
18 | if (line[0] == '+') | ||
19 | add_lines++; | ||
20 | |||
21 | else if (line[0] == '-') | ||
22 | rem_lines++; | ||
17 | } | 23 | } |
18 | 24 | ||
19 | void inspect_files(struct diff_filepair *pair) | 25 | void inspect_files(struct diff_filepair *pair) |
@@ -35,13 +41,14 @@ void print_commit(struct commit *commit) | |||
35 | sha1_to_hex(commit->object.sha1)); | 41 | sha1_to_hex(commit->object.sha1)); |
36 | if (cgit_repo->enable_log_filecount) { | 42 | if (cgit_repo->enable_log_filecount) { |
37 | files = 0; | 43 | files = 0; |
38 | lines = 0; | 44 | add_lines = 0; |
45 | rem_lines = 0; | ||
39 | cgit_diff_commit(commit, inspect_files); | 46 | cgit_diff_commit(commit, inspect_files); |
40 | html("</td><td class='right'>"); | 47 | html("</td><td class='right'>"); |
41 | htmlf("%d", files); | 48 | htmlf("%d", files); |
42 | if (cgit_repo->enable_log_linecount) { | 49 | if (cgit_repo->enable_log_linecount) { |
43 | html("</td><td class='right'>"); | 50 | html("</td><td class='right'>"); |
44 | htmlf("%d", lines); | 51 | htmlf("-%d/+%d", rem_lines, add_lines); |
45 | } | 52 | } |
46 | } | 53 | } |
47 | html("</td><td>"); | 54 | html("</td><td>"); |
@@ -88,9 +95,9 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern | |||
88 | "<th class='left'>Message</th>"); | 95 | "<th class='left'>Message</th>"); |
89 | 96 | ||
90 | if (cgit_repo->enable_log_filecount) { | 97 | if (cgit_repo->enable_log_filecount) { |
91 | html("<th class='left'>Files</th>"); | 98 | html("<th class='right'>Files</th>"); |
92 | if (cgit_repo->enable_log_linecount) | 99 | if (cgit_repo->enable_log_linecount) |
93 | html("<th class='left'>Lines</th>"); | 100 | html("<th class='right'>Lines</th>"); |
94 | } | 101 | } |
95 | html("<th class='left'>Author</th></tr>\n"); | 102 | html("<th class='left'>Author</th></tr>\n"); |
96 | 103 | ||