diff options
author | Lukas Fleischer | 2013-04-06 23:39:07 +0200 |
---|---|---|
committer | Jason A. Donenfeld | 2013-04-08 15:45:34 +0200 |
commit | caca860ba79fe9f6bc387f64ddb57ac0db1fac33 (patch) | |
tree | d395af44b56d3c5c53c83b0969b3b168e80a4910 | |
parent | 3edfd83db61f5dd2f046e6e8c21dfceeae03ed82 (diff) | |
download | cgit-caca860ba79fe9f6bc387f64ddb57ac0db1fac33.tar.gz cgit-caca860ba79fe9f6bc387f64ddb57ac0db1fac33.tar.bz2 cgit-caca860ba79fe9f6bc387f64ddb57ac0db1fac33.zip |
ui-refs.c: Remove global header variable
print_tag_header() is only called from cgit_print_tags() -- the
conditional invocation in print_tag() is never executed since
print_tag() is only called by cgit_print_tags() which already executes
print_tag_header() before (resulting in the global variable being always
set in when the condition is evaluated).
Remove the global variable and the conditional invocation.
Signed-off-by: Lukas Fleischer <cgit@cryptocrack.de>
-rw-r--r-- | ui-refs.c | 6 |
1 files changed, 0 insertions, 6 deletions
@@ -11,8 +11,6 @@ | |||
11 | #include "html.h" | 11 | #include "html.h" |
12 | #include "ui-shared.h" | 12 | #include "ui-shared.h" |
13 | 13 | ||
14 | static int header; | ||
15 | |||
16 | static int cmp_age(int age1, int age2) | 14 | static int cmp_age(int age1, int age2) |
17 | { | 15 | { |
18 | if (age1 != 0 && age2 != 0) | 16 | if (age1 != 0 && age2 != 0) |
@@ -96,7 +94,6 @@ static void print_tag_header() | |||
96 | "<th class='left'>Download</th>" | 94 | "<th class='left'>Download</th>" |
97 | "<th class='left'>Author</th>" | 95 | "<th class='left'>Author</th>" |
98 | "<th class='left' colspan='2'>Age</th></tr>\n"); | 96 | "<th class='left' colspan='2'>Age</th></tr>\n"); |
99 | header = 1; | ||
100 | } | 97 | } |
101 | 98 | ||
102 | static void print_tag_downloads(const struct cgit_repo *repo, const char *ref) | 99 | static void print_tag_downloads(const struct cgit_repo *repo, const char *ref) |
@@ -156,8 +153,6 @@ static int print_tag(struct refinfo *ref) | |||
156 | cgit_print_age(info->tagger_date, -1, NULL); | 153 | cgit_print_age(info->tagger_date, -1, NULL); |
157 | html("</td></tr>\n"); | 154 | html("</td></tr>\n"); |
158 | } else { | 155 | } else { |
159 | if (!header) | ||
160 | print_tag_header(); | ||
161 | html("<tr><td>"); | 156 | html("<tr><td>"); |
162 | cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); | 157 | cgit_tag_link(name, NULL, NULL, ctx.qry.head, name); |
163 | html("</td><td>"); | 158 | html("</td><td>"); |
@@ -221,7 +216,6 @@ void cgit_print_tags(int maxcount) | |||
221 | struct reflist list; | 216 | struct reflist list; |
222 | int i; | 217 | int i; |
223 | 218 | ||
224 | header = 0; | ||
225 | list.refs = NULL; | 219 | list.refs = NULL; |
226 | list.alloc = list.count = 0; | 220 | list.alloc = list.count = 0; |
227 | for_each_tag_ref(cgit_refs_cb, &list); | 221 | for_each_tag_ref(cgit_refs_cb, &list); |