diff options
author | John Keeping | 2013-05-18 18:46:38 +0100 |
---|---|---|
committer | Jason A. Donenfeld | 2013-05-22 12:53:06 +0200 |
commit | 75bfec6448b44e26c06736253f8ab0197a6652f7 (patch) | |
tree | df0fff85104702712c6d569a14f2749a8461970e | |
parent | 1e9f1ee64e5f8f75a361260a2165996bc137b961 (diff) | |
download | cgit-75bfec6448b44e26c06736253f8ab0197a6652f7.tar.gz cgit-75bfec6448b44e26c06736253f8ab0197a6652f7.tar.bz2 cgit-75bfec6448b44e26c06736253f8ab0197a6652f7.zip |
tests: introduce strip_header() helper function
This means that we can avoid hardcoding the number of headers we expect
CGit to generate in test cases and simply remove whatever headers happen
to by there when we are checking body content.
Signed-off-by: John Keeping <john@keeping.me.uk>
-rwxr-xr-x | tests/setup.sh | 8 | ||||
-rwxr-xr-x | tests/t0107-snapshot.sh | 4 |
2 files changed, 10 insertions, 2 deletions
diff --git a/tests/setup.sh b/tests/setup.sh index a573444..1d8677a 100755 --- a/tests/setup.sh +++ b/tests/setup.sh | |||
@@ -98,4 +98,12 @@ cgit_url() | |||
98 | CGIT_CONFIG="$PWD/cgitrc" QUERY_STRING="url=$1" cgit | 98 | CGIT_CONFIG="$PWD/cgitrc" QUERY_STRING="url=$1" cgit |
99 | } | 99 | } |
100 | 100 | ||
101 | strip_headers () { | ||
102 | while read -r line | ||
103 | do | ||
104 | test -z "$line" && break | ||
105 | done | ||
106 | cat | ||
107 | } | ||
108 | |||
101 | test -z "$CGIT_TEST_NO_CREATE_REPOS" && setup_repos | 109 | test -z "$CGIT_TEST_NO_CREATE_REPOS" && setup_repos |
diff --git a/tests/t0107-snapshot.sh b/tests/t0107-snapshot.sh index 053062c..6cf7aaa 100755 --- a/tests/t0107-snapshot.sh +++ b/tests/t0107-snapshot.sh | |||
@@ -16,7 +16,7 @@ test_expect_success 'check html headers' ' | |||
16 | ' | 16 | ' |
17 | 17 | ||
18 | test_expect_success 'strip off the header lines' ' | 18 | test_expect_success 'strip off the header lines' ' |
19 | tail -n +6 tmp > master.tar.gz | 19 | strip_headers <tmp >master.tar.gz |
20 | ' | 20 | ' |
21 | 21 | ||
22 | test_expect_success 'verify gzip format' ' | 22 | test_expect_success 'verify gzip format' ' |
@@ -51,7 +51,7 @@ test_expect_success 'check HTML headers (zip)' ' | |||
51 | ' | 51 | ' |
52 | 52 | ||
53 | test_expect_success 'strip off the header lines (zip)' ' | 53 | test_expect_success 'strip off the header lines (zip)' ' |
54 | tail -n +6 tmp >master.zip | 54 | strip_headers <tmp >master.zip |
55 | ' | 55 | ' |
56 | 56 | ||
57 | if test -n "$(which unzip 2>/dev/null)"; then | 57 | if test -n "$(which unzip 2>/dev/null)"; then |